Re: [Qemu-devel] [PATCH V6 21/29] qapi event: convert BLOCK_IMAGE_CORRUPTED

[Eric Blake]

On 06/05/2014 06:22 AM, Wenchao Xia wrote:
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>  block/qcow2-refcount.c  |   14 ++++++++------
>  docs/qmp/qmp-events.txt |   22 ----------------------
>  qapi-event.json         |   22 ++++++++++++++++++++++
>  3 files changed, 30 insertions(+), 28 deletions(-)
> 

> -- "device": Device name (json-string)
> -- "msg":    Informative message (e.g., reason for the corruption) 
> (json-string)
> -- "offset": If the corruption resulted from an image access, this is the 
> access
> -            offset into the image (json-int)
> -- "size":   If the corruption resulted from an image access, this is the 
> access
> -            size (json-int)
> -
> -Example:
> -
> -{ "event": "BLOCK_IMAGE_CORRUPTED",
> -    "data": { "device": "ide0-hd0",
> -        "msg": "Prevented active L1 table overwrite", "offset": 196608,

The old docs didn't make it clear...

> +#
> +# @msg: informative message, for example, reason for the corruption

...but the new docs should mention that msg is for human consumption and
should not be parsed by machine as it is not guaranteed to be stable

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature