[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V6 22/29] qapi event: convert other BLOCK_JOB ev
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V6 22/29] qapi event: convert other BLOCK_JOB events |
Date: |
Mon, 16 Jun 2014 16:57:13 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/05/2014 06:22 AM, Wenchao Xia wrote:
> Since BLOCK_JOB_COMPLETED, BLOCK_JOB_CANCELLED, BLOCK_JOB_READY are
> related, converts them in one patch. The block_job_event_* functions
s/converts/convert/
> are used to keep encapsulation of BlockJob structure.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> block/mirror.c | 2 +-
> blockdev.c | 12 +++----
> blockjob.c | 36 +++++++++++++----------
> docs/qmp/qmp-events.txt | 71
> ----------------------------------------------
> include/block/blockjob.h | 17 ++++++++--
> qapi-event.json | 71
> ++++++++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 110 insertions(+), 99 deletions(-)
>
> -- "device": Device name (json-string)
> -- "len": Maximum progress value (json-int)
> -- "offset": Current progress value (json-int)
> - On success this is equal to len.
> - On failure this is less than len.
> -- "speed": Rate limit, bytes per second (json-int)
> -- "error": Error message (json-string, optional)
> - Only present on failure. This field contains a human-readable
> - error message. There are no semantics other than that
> streaming
> - has failed and clients should not try to interpret the error
This sort of disclaimer is what I'm looking for in 21/29.
> /**
> - * qobject_from_block_job:
> + * block_job_event_cancle:
s/cancle/cancelled/
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH V6 16/29] qapi event: convert RTC_CHANGE, (continued)
[Qemu-devel] [PATCH V6 18/29] qapi event: convert DEVICE_DELETED, Wenchao Xia, 2014/06/05
[Qemu-devel] [PATCH V6 19/29] qapi event: convert DEVICE_TRAY_MOVED, Wenchao Xia, 2014/06/05
[Qemu-devel] [PATCH V6 20/29] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR, Wenchao Xia, 2014/06/05
[Qemu-devel] [PATCH V6 21/29] qapi event: convert BLOCK_IMAGE_CORRUPTED, Wenchao Xia, 2014/06/05
[Qemu-devel] [PATCH V6 22/29] qapi event: convert other BLOCK_JOB events, Wenchao Xia, 2014/06/05
- Re: [Qemu-devel] [PATCH V6 22/29] qapi event: convert other BLOCK_JOB events,
Eric Blake <=
[Qemu-devel] [PATCH V6 23/29] qapi event: convert NIC_RX_FILTER_CHANGED, Wenchao Xia, 2014/06/05
[Qemu-devel] [PATCH V6 24/29] qapi event: convert VNC events, Wenchao Xia, 2014/06/05
[Qemu-devel] [PATCH V6 25/29] qapi event: convert SPICE events, Wenchao Xia, 2014/06/05
[Qemu-devel] [PATCH V6 26/29] qapi event: convert BALLOON_CHANGE, Wenchao Xia, 2014/06/05
[Qemu-devel] [PATCH V6 28/29] qapi event: convert QUORUM events, Wenchao Xia, 2014/06/05
[Qemu-devel] [PATCH V6 27/29] qapi event: convert GUEST_PANICKED, Wenchao Xia, 2014/06/05
[Qemu-devel] [PATCH V6 29/29] qapi event: clean up, Wenchao Xia, 2014/06/05