[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/16] qapi: Drop bogus command from docs
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 02/16] qapi: Drop bogus command from docs |
Date: |
Fri, 12 Jun 2015 16:51:59 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/12/2015 08:51 AM, Markus Armbruster wrote:
> Commit 87a560c4 added it in the wrong place. Commit 59a2c4ce added it
> in the right place, but didn't remove it from the wrong place. Do
> that now.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> docs/qapi-code-gen.txt | 2 --
> 1 file changed, 2 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
> diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt
> index 3f0522e..61b5be4 100644
> --- a/docs/qapi-code-gen.txt
> +++ b/docs/qapi-code-gen.txt
> @@ -680,8 +680,6 @@ Example:
> out:
> error_propagate(errp, err);
> }
> - $ python scripts/qapi-commands.py --output-dir="qapi-generated" \
> - --prefix="example-" example-schema.json
> $ cat qapi-generated/example-qapi-visit.h
> [Uninteresting stuff omitted...]
I did a double take there before realizing it was context of the
existing file, and not you hand-editing your patch email :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/16] qapi: Miscellaneous fixes and cleanups, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 01/16] MAINTAINERS: Fix up QAPI and QAPI schema file patterns, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 04/16] qapi: Eliminate superfluous QAPISchema attribute include_hist, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 03/16] qapi: Eliminate superfluous QAPISchema attribute input_dir, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 02/16] qapi: Drop bogus command from docs, Markus Armbruster, 2015/06/12
- Re: [Qemu-devel] [PATCH 02/16] qapi: Drop bogus command from docs,
Eric Blake <=
- [Qemu-devel] [PATCH 13/16] qapi-types: Don't filter out expressions with 'gen', Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 12/16] qapi: Catch and reject flat union branch of array type, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 06/16] qapi: Fix file name in error messages for included files, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 07/16] qapi: Simplify inclusion cycle detection, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 08/16] qapi: Fix to reject stray 't', 'f' and 'n', Markus Armbruster, 2015/06/12