[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/16] qapi: Fix file name in error messages for
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 06/16] qapi: Fix file name in error messages for included files |
Date: |
Fri, 12 Jun 2015 17:19:40 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/12/2015 08:51 AM, Markus Armbruster wrote:
> We print the name as it appears in the include expression. Tools
> processing error messages want it relative to the working directory.
> Make it so.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scripts/qapi.py | 7 +++----
> tests/qapi-schema/include-cycle.err | 4 ++--
> tests/qapi-schema/include-nested-err.err | 2 +-
> 3 files changed, 6 insertions(+), 7 deletions(-)
>
> +++ b/tests/qapi-schema/include-cycle.err
> @@ -1,3 +1,3 @@
> In file included from tests/qapi-schema/include-cycle.json:1:
> -In file included from include-cycle-b.json:1:
> -include-cycle-c.json:1: Inclusion loop for include-cycle.json
> +In file included from tests/qapi-schema/include-cycle-b.json:1:
> +tests/qapi-schema/include-cycle-c.json:1: Inclusion loop for
> include-cycle.json
> diff --git a/tests/qapi-schema/include-nested-err.err
> b/tests/qapi-schema/include-nested-err.err
> index 1dacbda..1b7b227 100644
> --- a/tests/qapi-schema/include-nested-err.err
> +++ b/tests/qapi-schema/include-nested-err.err
> @@ -1,2 +1,2 @@
> In file included from tests/qapi-schema/include-nested-err.json:1:
> -missing-colon.json:1:10: Expected ":"
> +tests/qapi-schema/missing-colon.json:1:10: Expected ":"
Yes, that's nicer to read. Interesting that deleting a parameter makes
life better!
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 04/16] qapi: Eliminate superfluous QAPISchema attribute include_hist, (continued)
- [Qemu-devel] [PATCH 03/16] qapi: Eliminate superfluous QAPISchema attribute input_dir, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 02/16] qapi: Drop bogus command from docs, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 13/16] qapi-types: Don't filter out expressions with 'gen', Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 12/16] qapi: Catch and reject flat union branch of array type, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 06/16] qapi: Fix file name in error messages for included files, Markus Armbruster, 2015/06/12
- Re: [Qemu-devel] [PATCH 06/16] qapi: Fix file name in error messages for included files,
Eric Blake <=
- [Qemu-devel] [PATCH 07/16] qapi: Simplify inclusion cycle detection, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 08/16] qapi: Fix to reject stray 't', 'f' and 'n', Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 05/16] qapi: Improve a couple of confusing variable names, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 14/16] qapi-types: Drop unused members parameters, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 16/16] qapi-types: Bury code dead since commit 6b5abc7, Markus Armbruster, 2015/06/12