[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/16] qapi: Eliminate superfluous QAPISchema at
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 04/16] qapi: Eliminate superfluous QAPISchema attribute include_hist |
|
Date: |
Fri, 12 Jun 2015 17:11:44 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/12/2015 08:51 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scripts/qapi.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Ah, I see - you're changing it from an object member to a local variable
(because it didn't need to persist beyond the one function).
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/16] qapi: Miscellaneous fixes and cleanups, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 01/16] MAINTAINERS: Fix up QAPI and QAPI schema file patterns, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 04/16] qapi: Eliminate superfluous QAPISchema attribute include_hist, Markus Armbruster, 2015/06/12
- Re: [Qemu-devel] [PATCH 04/16] qapi: Eliminate superfluous QAPISchema attribute include_hist,
Eric Blake <=
- [Qemu-devel] [PATCH 03/16] qapi: Eliminate superfluous QAPISchema attribute input_dir, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 02/16] qapi: Drop bogus command from docs, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 13/16] qapi-types: Don't filter out expressions with 'gen', Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 12/16] qapi: Catch and reject flat union branch of array type, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 06/16] qapi: Fix file name in error messages for included files, Markus Armbruster, 2015/06/12