qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/16] qapi: Eliminate superfluous QAPISchema at


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 04/16] qapi: Eliminate superfluous QAPISchema attribute include_hist
Date: Tue, 16 Jun 2015 10:43:46 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 06/12/2015 08:51 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  scripts/qapi.py | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>
> Ah, I see - you're changing it from an object member to a local variable
> (because it didn't need to persist beyond the one function).

Exactly.

I could explain it the commit message, but I think I'll just squash it
into PATCH 07.

> Reviewed-by: Eric Blake <address@hidden>

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]