[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/16] qapi: Eliminate superfluous QAPISchema at
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 04/16] qapi: Eliminate superfluous QAPISchema attribute include_hist |
Date: |
Tue, 16 Jun 2015 10:43:46 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 06/12/2015 08:51 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> scripts/qapi.py | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>
> Ah, I see - you're changing it from an object member to a local variable
> (because it didn't need to persist beyond the one function).
Exactly.
I could explain it the commit message, but I think I'll just squash it
into PATCH 07.
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- [Qemu-devel] [PATCH 00/16] qapi: Miscellaneous fixes and cleanups, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 01/16] MAINTAINERS: Fix up QAPI and QAPI schema file patterns, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 04/16] qapi: Eliminate superfluous QAPISchema attribute include_hist, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 03/16] qapi: Eliminate superfluous QAPISchema attribute input_dir, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 02/16] qapi: Drop bogus command from docs, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 13/16] qapi-types: Don't filter out expressions with 'gen', Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 12/16] qapi: Catch and reject flat union branch of array type, Markus Armbruster, 2015/06/12
- [Qemu-devel] [PATCH 06/16] qapi: Fix file name in error messages for included files, Markus Armbruster, 2015/06/12