[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass thr
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr |
Date: |
Thu, 18 Jun 2015 10:16:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 18/06/2015 07:17, Pavel Dovgaluk wrote:
>>> > >
>>> > > static inline RES_TYPE
>>> > > -glue(glue(cpu_ld, USUFFIX), MEMSUFFIX)(CPUArchState *env, target_ulong
>>> > > ptr)
>>> > > +glue(glue(glue(cpu_ld, USUFFIX), MEMSUFFIX), _ra)(CPUArchState *env,
>>> > > + target_ulong ptr,
>>> > > + uintptr_t retaddr)
>> >
>> > Would it make sense to call these helper_cpu_ld##USUFFIX##MEMSUFFIX?
> I don't want to use 'helper' prefix, because helper functions are
> usually called directly from TB.
True, but in the end these have the same functionality as helpers, just
they're indirectly called from other helpers.
Paolo
- [Qemu-devel] [PATCH v2 0/3] Fix exceptions handling for MIPS and i386, Pavel Dovgalyuk, 2015/06/17
- [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr, Pavel Dovgalyuk, 2015/06/17
- Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr, Pavel Dovgaluk, 2015/06/18
- Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr, Paolo Bonzini, 2015/06/18
- Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr, Pavel Dovgaluk, 2015/06/18
- Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr, Paolo Bonzini, 2015/06/18
[Qemu-devel] [PATCH v2 2/3] target-mips: exceptions handling in icount mode, Pavel Dovgalyuk, 2015/06/17
[Qemu-devel] [PATCH v2 3/3] target-i386: fix memory operations in helpers, Pavel Dovgalyuk, 2015/06/17
Re: [Qemu-devel] [PATCH v2 0/3] Fix exceptions handling for MIPS and i386, Aurelien Jarno, 2015/06/17