Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr

[Paolo Bonzini]

On 18/06/2015 11:24, Pavel Dovgaluk wrote:
>>> > > +uint16_t helper_call_ldw_cmmu(CPUArchState *env, target_ulong addr,
>>> > > +                              int mmu_idx, uintptr_t retaddr);
>> > 
>> > What about helper_ret_ldw_cmmu for consistency with the DATA_SIZE == 1 
>> > case?
> tcg.h breaks these definitions:
> 
> /* Temporary aliases until backends are converted.  */
> #ifdef TARGET_WORDS_BIGENDIAN
> # define helper_ret_ldsw_mmu  helper_be_ldsw_mmu
> # define helper_ret_lduw_mmu  helper_be_lduw_mmu
> # define helper_ret_ldsl_mmu  helper_be_ldsl_mmu
> # define helper_ret_ldul_mmu  helper_be_ldul_mmu
> # define helper_ret_ldq_mmu   helper_be_ldq_mmu
> # define helper_ret_stw_mmu   helper_be_stw_mmu
> # define helper_ret_stl_mmu   helper_be_stl_mmu
> # define helper_ret_stq_mmu   helper_be_stq_mmu
> #else

Isn't this exactly the same as your helper_call_ldw_cmmu?

Paolo