[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS] [PATCH 03/18] virtio: add struct vp_device
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [SeaBIOS] [PATCH 03/18] virtio: add struct vp_device |
Date: |
Tue, 30 Jun 2015 08:31:04 +0200 |
Hi,
> > Is there a reason to make this a pointer as opposed to just placing
> > the vp_device struct directly in struct virtiodrive_s?
>
> That'll work too, both blk and scsi have a struct where we can place
> vp_device inside. I'll change it for v2.
Oops, wrong. For virtio-blk it works, but for virtio-scsi all devices
connected to the host adapter share one vp_device instance. And a
per-hostadapter data structure doesn't exist because we don't need one.
cheers,
Gerd
[Qemu-devel] [PATCH 07/18] virtio: add version 1.0 read/write macros, Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 08/18] virtio: make features 64bit, support version 1.0 features, Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 09/18] virtio: add version 1.0 support to vp_{get, set}_status, Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 10/18] virtio: add version 1.0 support to vp_get_isr, Gerd Hoffmann, 2015/06/29