[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/9] virtio-dataplane: pass assign=true to virti
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/9] virtio-dataplane: pass assign=true to virtio_queue_aio_set_host_notifier_handler |
|
Date: |
Wed, 30 Mar 2016 15:23:55 +0200 |
On Wed, 30 Mar 2016 14:48:00 +0200
Paolo Bonzini <address@hidden> wrote:
> There is no need to run the handler one last time; the device is being
> reset and it is okay to drop requests that are pending in the virtqueue.
What about virtio_blk_save()? Could there be any pending requests in
that case?
> By omitting this call, we dodge a possible cause of races between the
> dataplane thread on one side and the main/vCPU threads on the other.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/block/dataplane/virtio-blk.c | 2 +-
> hw/scsi/virtio-scsi-dataplane.c | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)