[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/9] virtio-scsi: fix disabled mode
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 4/9] virtio-scsi: fix disabled mode |
Date: |
Wed, 30 Mar 2016 16:52:45 +0200 |
On Wed, 30 Mar 2016 14:48:03 +0200
Paolo Bonzini <address@hidden> wrote:
> Add two missing checks for s->dataplane_fenced. In one case, QEMU
> would skip injecting an IRQ due to a write to an uninitialized
> EventNotifier's file descriptor.
>
> In the second case, the dataplane_disabled field was used by mistake;
> in fact after fixing this occurrence it is completely unused.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/scsi/virtio-scsi.c | 4 ++--
> include/hw/virtio/virtio-scsi.h | 1 -
> 2 files changed, 2 insertions(+), 3 deletions(-)
It's a bit confusing that the disabled mode for virtio-scsi dataplane
uses 'fenced' instead of 'disabled', but 'disabled' was already used...
Reviewed-by: Cornelia Huck <address@hidden>
- [Qemu-devel] [PATCH resend 0/9] virtio: aio handler API, Paolo Bonzini, 2016/03/30
- [Qemu-devel] [PATCH 4/9] virtio-scsi: fix disabled mode, Paolo Bonzini, 2016/03/30
- Re: [Qemu-devel] [PATCH 4/9] virtio-scsi: fix disabled mode,
Cornelia Huck <=
- [Qemu-devel] [PATCH 5/9] virtio: add aio handler, Paolo Bonzini, 2016/03/30
- [Qemu-devel] [PATCH 2/9] virtio: make virtio_queue_notify_vq static, Paolo Bonzini, 2016/03/30
- [Qemu-devel] [PATCH 6/9] virtio-blk: use aio handler for data plane, Paolo Bonzini, 2016/03/30
- [Qemu-devel] [PATCH 7/9] virtio-scsi: use aio handler for data plane, Paolo Bonzini, 2016/03/30