[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/9] virtio-blk: fix disabled mode
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 3/9] virtio-blk: fix disabled mode |
Date: |
Wed, 30 Mar 2016 15:57:58 +0200 |
On Wed, 30 Mar 2016 14:48:02 +0200
Paolo Bonzini <address@hidden> wrote:
> The missing check on dataplane_disabled caused a segmentation
> fault in notify_guest_bh, because s->guest_notifier was NULL.
I think this patch description could be improved :)
"We must not call virtio_blk_data_plane_notify if dataplane is
disabled: we would hit a segmentation fault in notify_guest_bh as
s->guest_notifier has not been setup and is NULL."
?
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/block/dataplane/virtio-blk.c | 7 +++----
> hw/block/virtio-blk.c | 2 +-
> include/hw/virtio/virtio-blk.h | 1 +
> 3 files changed, 5 insertions(+), 5 deletions(-)
Patch looks good:
Reviewed-by: Cornelia Huck <address@hidden>