[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/4] target/arm: handle M-profile semihosting
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v1 1/4] target/arm: handle M-profile semihosting at translate time |
Date: |
Thu, 04 Jul 2019 11:21:54 +0100 |
User-agent: |
mu4e 1.3.2; emacs 26.1 |
Richard Henderson <address@hidden> writes:
> On 7/3/19 5:52 PM, Alex Bennée wrote:
>> +static inline void gen_thumb_bkpt(DisasContext *s, int imm8)
>> +{
>> + if (arm_dc_feature(s, ARM_FEATURE_M) &&
>> + semihosting_enabled() &&
>> +#ifndef CONFIG_USER_ONLY
>> + s->current_el != 0 &&
>> +#endif
>> + (imm8 == 0xab)) {
>
> Extra parenthesis.
The wrapping on imm8 == 0xab? Do you want that cleaned up on the other
patches as well?
> Otherwise,
> Reviewed-by: Richard Henderson <address@hidden>
>
>
> r~
--
Alex Bennée
[Qemu-devel] [PATCH v1 4/4] target/arm: remove run time semihosting checks, Alex Bennée, 2019/07/03
Re: [Qemu-devel] [PATCH v1 4/4] target/arm: remove run time semihosting checks, Richard Henderson, 2019/07/03
Re: [Qemu-devel] [PATCH v1 0/4] arm semihosting cleanups, no-reply, 2019/07/03