qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 1/4] target/arm: handle M-profile semihosting


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH v1 1/4] target/arm: handle M-profile semihosting at translate time
Date: Thu, 4 Jul 2019 12:25:22 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0


On 7/4/19 12:21 PM, Alex Bennée wrote:
> 
> Richard Henderson <address@hidden> writes:
> 
>> On 7/3/19 5:52 PM, Alex Bennée wrote:
>>> +static inline void gen_thumb_bkpt(DisasContext *s, int imm8)
>>> +{
>>> +    if (arm_dc_feature(s, ARM_FEATURE_M) &&
>>> +        semihosting_enabled() &&
>>> +#ifndef CONFIG_USER_ONLY
>>> +        s->current_el != 0 &&
>>> +#endif
>>> +        (imm8 == 0xab)) {
>>
>> Extra parenthesis.
> 
> The wrapping on imm8 == 0xab? Do you want that cleaned up on the other
> patches as well?

I understood this comment for "(s->current_el != 0) &&"



reply via email to

[Prev in Thread] Current Thread [Next in Thread]