Re: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
43520aa target/rx: remove unused functions.
8c4fa37 BootLinuxConsoleTest: Test the RX-Virt machine
04564e4 Add rx-softmmu
9378055 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
623d106 hw/rx: Honor -accel qtest
ce90108 hw/rx: RX Target hardware definition
5e1fd91 hw/char: RX62N serial communication interface (SCI)
ed12e4f hw/timer: RX62N internal timer modules
4ee171f hw/intc: RX62N interrupt controller (ICUa)
3e99d3a target/rx: Dump bytes for each insn during disassembly
8ab5e5a target/rx: Collect all bytes during disassembly
bfc0549 target/rx: Emit all disassembly in one prt()
8bc54a1 target/rx: Use prt_ldmi for XCHG_mr disassembly
c337f3e target/rx: Replace operand with prt_ldmi in disassembler
06f56ef target/rx: Disassemble rx_index_addr into a string
29174101 target/rx: RX disassembler
c693655 target/rx: CPU definition
439bd90 target/rx: TCG helper
83dfefb target/rx: TCG translation
3f7fb72 hw/registerfields.h: Add 8bit and 16bit register macros
260aa39 qemu/bitops.h: Add extract8 and extract16
7059b8f MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit 7059b8fb4490 (MAINTAINERS: Add RX)
2/22 Checking commit 260aa39095f4 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 3f7fb72b73e5 (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2467.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit 83dfefba5ed1 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 439bd90293d1 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
new file mode 100644

total: 0 errors, 1 warnings, 649 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit c69365510576 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 622 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 29174101dd66 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 06f56ef1f68d (target/rx: Disassemble rx_index_addr into a 
string)
9/22 Checking commit c337f3e82978 (target/rx: Replace operand with prt_ldmi in 
disassembler)
10/22 Checking commit 8bc54a18e392 (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
11/22 Checking commit bfc054910893 (target/rx: Emit all disassembly in one 
prt())
12/22 Checking commit 8ab5e5a64531 (target/rx: Collect all bytes during 
disassembly)
13/22 Checking commit 3e99d3a17590 (target/rx: Dump bytes for each insn during 
disassembly)
14/22 Checking commit 4ee171f1b30c (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit ed12e4f78ded (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 839 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 5e1fd91ae9ec (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit ce90108ec40b (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 479 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit 623d1066205d (hw/rx: Honor -accel qtest)
19/22 Checking commit 9378055ee6b5 (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
20/22 Checking commit 04564e411abc (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 73 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 8c4fa379bd21 (BootLinuxConsoleTest: Test the RX-Virt 
machine)
22/22 Checking commit 43520aa2a410 (target/rx: remove unused functions.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
deleted file mode 100644

total: 0 errors, 1 warnings, 5 lines checked

Patch 22/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden