qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support


From: no-reply
Subject: Re: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support
Date: Fri, 5 Jul 2019 16:59:40 -0700 (PDT)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
768db26 target/rx: remove unused functions.
ed8a99e BootLinuxConsoleTest: Test the RX-Virt machine
ce60411 Add rx-softmmu
c5fdb33 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
42ed9fc hw/rx: Honor -accel qtest
0af198e hw/rx: RX Target hardware definition
9dba70d hw/char: RX62N serial communication interface (SCI)
bb02bef hw/timer: RX62N internal timer modules
84a988c hw/intc: RX62N interrupt controller (ICUa)
214861a target/rx: Dump bytes for each insn during disassembly
bc5426a target/rx: Collect all bytes during disassembly
be621d1 target/rx: Emit all disassembly in one prt()
c033e57 target/rx: Use prt_ldmi for XCHG_mr disassembly
8c061e4 target/rx: Replace operand with prt_ldmi in disassembler
5fd1d69 target/rx: Disassemble rx_index_addr into a string
4b360ac target/rx: RX disassembler
5900729 target/rx: CPU definition
a2a8f4d target/rx: TCG helper
4bafc3d target/rx: TCG translation
cba7819 hw/registerfields.h: Add 8bit and 16bit register macros
9a9de6e qemu/bitops.h: Add extract8 and extract16
8ca7f4f MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit 8ca7f4ffdd07 (MAINTAINERS: Add RX)
2/22 Checking commit 9a9de6ed241d (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit cba7819b1f0a (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2467.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit 4bafc3dd09d7 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit a2a8f4dcb738 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
new file mode 100644

total: 0 errors, 1 warnings, 649 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 5900729079cb (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 622 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 4b360ac5c2a1 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 5fd1d69a85e3 (target/rx: Disassemble rx_index_addr into a 
string)
9/22 Checking commit 8c061e412fe5 (target/rx: Replace operand with prt_ldmi in 
disassembler)
10/22 Checking commit c033e579b386 (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
11/22 Checking commit be621d169e8f (target/rx: Emit all disassembly in one 
prt())
12/22 Checking commit bc5426af2c01 (target/rx: Collect all bytes during 
disassembly)
13/22 Checking commit 214861ad93dd (target/rx: Dump bytes for each insn during 
disassembly)
14/22 Checking commit 84a988cacd5a (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit bb02bef98a66 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 839 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 9dba70d97cc3 (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 0af198e5a81a (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 479 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit 42ed9fca92ce (hw/rx: Honor -accel qtest)
19/22 Checking commit c5fdb334b58d (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
20/22 Checking commit ce6041163bda (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 73 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit ed8a99eab0f7 (BootLinuxConsoleTest: Test the RX-Virt 
machine)
22/22 Checking commit 768db267f825 (target/rx: remove unused functions.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
deleted file mode 100644

total: 0 errors, 1 warnings, 5 lines checked

Patch 22/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]