Re: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
7b6c672 target/rx: remove unused functions.
f631f26 BootLinuxConsoleTest: Test the RX-Virt machine
ae956c0 Add rx-softmmu
f32fa6f hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
2e4b3a7 hw/rx: Honor -accel qtest
33132af hw/rx: RX Target hardware definition
037b5f7 hw/char: RX62N serial communication interface (SCI)
af608ff hw/timer: RX62N internal timer modules
61c2a93 hw/intc: RX62N interrupt controller (ICUa)
17dfb71 target/rx: Dump bytes for each insn during disassembly
464b24d target/rx: Collect all bytes during disassembly
b60817a target/rx: Emit all disassembly in one prt()
a6852a9 target/rx: Use prt_ldmi for XCHG_mr disassembly
85bd9b8 target/rx: Replace operand with prt_ldmi in disassembler
1e8f6a8 target/rx: Disassemble rx_index_addr into a string
7cc9c8a target/rx: RX disassembler
4601333 target/rx: CPU definition
288586d target/rx: TCG helper
f6e6413 target/rx: TCG translation
ca8f38f hw/registerfields.h: Add 8bit and 16bit register macros
2b91785 qemu/bitops.h: Add extract8 and extract16
de03b2e MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit de03b2eadbbb (MAINTAINERS: Add RX)
2/22 Checking commit 2b9178589b66 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit ca8f38f84b15 (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2467.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit f6e6413f5d9c (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 288586d1dedb (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
new file mode 100644

total: 0 errors, 1 warnings, 649 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 46013335befe (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 622 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 7cc9c8a1242f (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 1e8f6a89b733 (target/rx: Disassemble rx_index_addr into a 
string)
9/22 Checking commit 85bd9b87bdcf (target/rx: Replace operand with prt_ldmi in 
disassembler)
10/22 Checking commit a6852a9b457d (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
11/22 Checking commit b60817aca52a (target/rx: Emit all disassembly in one 
prt())
12/22 Checking commit 464b24d782c6 (target/rx: Collect all bytes during 
disassembly)
13/22 Checking commit 17dfb715770c (target/rx: Dump bytes for each insn during 
disassembly)
14/22 Checking commit 61c2a933c0d2 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit af608ff329e7 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 839 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 037b5f7c0476 (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 33132afa04d0 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 479 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit 2e4b3a7c42c3 (hw/rx: Honor -accel qtest)
19/22 Checking commit f32fa6fe3667 (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
20/22 Checking commit ae956c0ae588 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 73 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit f631f2648e7a (BootLinuxConsoleTest: Test the RX-Virt 
machine)
22/22 Checking commit 7b6c672a33ee (target/rx: remove unused functions.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
deleted file mode 100644

total: 0 errors, 1 warnings, 5 lines checked

Patch 22/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden