Re: [Qemu-devel] [PATCH v2 12/29] Include hw/irq.h a lot less

[Eric Blake]

On 8/7/19 8:04 AM, Philippe Mathieu-Daudé wrote:
> On 8/6/19 5:14 PM, Markus Armbruster wrote:
>> In my "build everything" tree, changing hw/irq.h triggers a recompile
>> of some 5400 out of 6600 objects (not counting tests and objects that
>> don't depend on qemu/osdep.h).
>>
>> hw/hw.h supposedly includes it for convenience.  Several other headers
>> include it just to get qemu_irq and.or qemu_irq_handler.
>>
>> Move the qemu_irq and qemu_irq_handler typedefs from hw/irq.h to
>> qemu/typedefs.h, and then include hw/irq.h only where it's still
>> needed.  Touching it now recompiles only some 500 objects.
>>

>>  /*
>>   * Function types
>>   */
>>  typedef void SaveStateHandler(QEMUFile *f, void *opaque);
>>  typedef int LoadStateHandler(QEMUFile *f, void *opaque, int version_id);
>> +typedef void (*qemu_irq_handler)(void *opaque, int n, int level);

Should we prefer a consistent form for function pointer typedefs?  Here,
we've mixed 'rettype Name(params)' with 'rettype (*name)(params)'.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature