[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [EXTERNAL][PATCH v8 12/37] target/mips: Style improveme
From: |
Aleksandar Rikalo |
Subject: |
Re: [Qemu-devel] [EXTERNAL][PATCH v8 12/37] target/mips: Style improvements in cps.c |
Date: |
Mon, 19 Aug 2019 14:44:56 +0000 |
> From: Aleksandar Markovic <address@hidden>
> Sent: Monday, August 19, 2019 2:07 PM
> To: address@hidden <address@hidden>
> Cc: address@hidden <address@hidden>; Aleksandar Markovic <address@hidden>;
> Aleksandar Rikalo <address@hidden>
> Subject: [EXTERNAL][PATCH v8 12/37] target/mips: Style improvements in cps.c
>
> From: Aleksandar Markovic <address@hidden>
>
> Fixes mostly errors and warnings reported by 'checkpatch.pl -f'.
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
> hw/mips/cps.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/mips/cps.c b/hw/mips/cps.c
> index c84bc64..8fe2f47 100644
> --- a/hw/mips/cps.c
> +++ b/hw/mips/cps.c
> @@ -37,8 +37,10 @@ static void mips_cps_init(Object *obj)
> SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
> MIPSCPSState *s = MIPS_CPS(obj);
>
> - /* Cover entire address space as there do not seem to be any
> - * constraints for the base address of CPC and GIC. */
> + /*
> + * Cover entire address space as there do not seem to be any
> + * constraints for the base address of CPC and GIC.
> + */
> memory_region_init(&s->container, obj, "mips-cps-container", UINT64_MAX);
> sysbus_init_mmio(sbd, &s->container);
> }
> --
> 2.7.4
Reviewed-by: Aleksandar Rikalo <address@hidden>
- Re: [Qemu-devel] [EXTERNAL][PATCH v8 03/37] target/mips: Amend CP0 MemoryMapID register implementation, (continued)
- [Qemu-devel] [PATCH v8 09/37] target/mips: Style improvements in machine.c, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 08/37] target/mips: Style improvements in internal.h, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 01/37] target/mips: Add support for DSPRAM, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 10/37] target/mips: Style improvements in helper.c, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 04/37] target/mips: Add support for emulation of GINVT instruction, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 12/37] target/mips: Style improvements in cps.c, Aleksandar Markovic, 2019/08/19
- Re: [Qemu-devel] [EXTERNAL][PATCH v8 12/37] target/mips: Style improvements in cps.c,
Aleksandar Rikalo <=
- [Qemu-devel] [PATCH v8 16/37] target/mips: Style improvements in mips_mipssim.c, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 13/37] target/mips: Style improvements in mips_fulong2e.c, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 05/37] target/mips: Add support for emulation of CRC32 group of instructions, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 14/37] target/mips: Style improvements in mips_int.c, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 23/37] target/mips: Clean up handling of CP0 register 8, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 06/37] target/mips: Style improvements in cp0_timer.c, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 25/37] target/mips: Clean up handling of CP0 register 11, Aleksandar Markovic, 2019/08/19