[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [EXTERNAL][PATCH v8 14/37] target/mips: Style improveme
From: |
Aleksandar Rikalo |
Subject: |
Re: [Qemu-devel] [EXTERNAL][PATCH v8 14/37] target/mips: Style improvements in mips_int.c |
Date: |
Mon, 19 Aug 2019 14:46:41 +0000 |
From: Aleksandar Markovic <address@hidden>
> Sent: Monday, August 19, 2019 2:07 PM
> To: address@hidden <address@hidden>
> Cc: address@hidden <address@hidden>; Aleksandar Markovic <address@hidden>;
> Aleksandar Rikalo <address@hidden>
> Subject: [EXTERNAL][PATCH v8 14/37] target/mips: Style improvements in
> mips_int.c
>
> From: Aleksandar Markovic <address@hidden>
>
> Fixes mostly errors and warnings reported by 'checkpatch.pl -f'.
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
> hw/mips/mips_int.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c
> index f899f6c..4c731ab 100644
> --- a/hw/mips/mips_int.c
> +++ b/hw/mips/mips_int.c
> @@ -35,8 +35,9 @@ static void cpu_mips_irq_request(void *opaque, int irq, int
> level)
> CPUState *cs = CPU(cpu);
> bool locked = false;
>
> - if (irq < 0 || irq > 7)
> + if (irq < 0 || irq > 7) {
> return;
> + }
>
> /* Make sure locking works even if BQL is already held by the caller */
> if (!qemu_mutex_iothread_locked()) {
> --
> 2.7.4
>
Reviewed-by: Aleksandar Rikalo <address@hidden>
- Re: [Qemu-devel] [EXTERNAL][PATCH v8 10/37] target/mips: Style improvements in helper.c, (continued)
- [Qemu-devel] [PATCH v8 04/37] target/mips: Add support for emulation of GINVT instruction, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 12/37] target/mips: Style improvements in cps.c, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 16/37] target/mips: Style improvements in mips_mipssim.c, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 13/37] target/mips: Style improvements in mips_fulong2e.c, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 05/37] target/mips: Add support for emulation of CRC32 group of instructions, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 14/37] target/mips: Style improvements in mips_int.c, Aleksandar Markovic, 2019/08/19
- Re: [Qemu-devel] [EXTERNAL][PATCH v8 14/37] target/mips: Style improvements in mips_int.c,
Aleksandar Rikalo <=
- [Qemu-devel] [PATCH v8 23/37] target/mips: Clean up handling of CP0 register 8, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 06/37] target/mips: Style improvements in cp0_timer.c, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 25/37] target/mips: Clean up handling of CP0 register 11, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 22/37] target/mips: Clean up handling of CP0 register 7, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 18/37] target/mips: Clean up handling of CP0 register 1, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 21/37] target/mips: Clean up handling of CP0 register 6, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 28/37] target/mips: Clean up handling of CP0 register 16, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 19/37] target/mips: Clean up handling of CP0 register 2, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 29/37] target/mips: Clean up handling of CP0 register 17, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 27/37] target/mips: Clean up handling of CP0 register 15, Aleksandar Markovic, 2019/08/19