Re: [PATCH v26 00/21] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v26 00/21] Add RX archtecture support
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
4c3dad1 BootLinuxConsoleTest: Test the RX-Virt machine
c142990 Add rx-softmmu
3399475 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
9bee373 hw/rx: Honor -accel qtest
5d46dd8 hw/rx: RX Target hardware definition
045dde2 hw/char: RX62N serial communication interface (SCI)
e083fdb hw/timer: RX62N internal timer modules
7007342 hw/intc: RX62N interrupt controller (ICUa)
abaefff target/rx: Dump bytes for each insn during disassembly
c47d1b5 target/rx: Collect all bytes during disassembly
caf127b target/rx: Emit all disassembly in one prt()
b384a35 target/rx: Use prt_ldmi for XCHG_mr disassembly
4f1a429 target/rx: Replace operand with prt_ldmi in disassembler
0497516 target/rx: Disassemble rx_index_addr into a string
e557d70 target/rx: RX disassembler
87a65d0 target/rx: CPU definition
b7f549f target/rx: TCG helper
cb05be5 target/rx: TCG translation
40b374c hw/registerfields.h: Add 8bit and 16bit register macros
1d0ff9c qemu/bitops.h: Add extract8 and extract16
6eaeb50 MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/21 Checking commit 6eaeb50b4cee (MAINTAINERS: Add RX)
2/21 Checking commit 1d0ff9ca2614 (qemu/bitops.h: Add extract8 and extract16)
3/21 Checking commit 40b374cf6a64 (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/21 Checking commit cb05be5ae845 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/21 Checking commit b7f549ffd63a (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/21 Checking commit 87a65d07c493 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

total: 0 errors, 1 warnings, 588 lines checked

Patch 6/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/21 Checking commit e557d7025ecf (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/21 Checking commit 0497516a2518 (target/rx: Disassemble rx_index_addr into a 
string)
9/21 Checking commit 4f1a4299e204 (target/rx: Replace operand with prt_ldmi in 
disassembler)
10/21 Checking commit b384a35fdae4 (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
11/21 Checking commit caf127b72272 (target/rx: Emit all disassembly in one 
prt())
12/21 Checking commit c47d1b5dcc35 (target/rx: Collect all bytes during 
disassembly)
13/21 Checking commit abaefffa341e (target/rx: Dump bytes for each insn during 
disassembly)
14/21 Checking commit 700734263aef (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/21 Checking commit e083fdb0c716 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/21 Checking commit 045dde28e03a (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 401 lines checked

Patch 16/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/21 Checking commit 5d46dd871e1b (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 480 lines checked

Patch 17/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/21 Checking commit 9bee373b0ea8 (hw/rx: Honor -accel qtest)
19/21 Checking commit 33994759788c (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
20/21 Checking commit c142990c2ff1 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

total: 0 errors, 1 warnings, 74 lines checked

Patch 20/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/21 Checking commit 4c3dad1103b8 (BootLinuxConsoleTest: Test the RX-Virt 
machine)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden