Re: [PATCH v26 00/21] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v26 00/21] Add RX archtecture support
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
e7b4c1e BootLinuxConsoleTest: Test the RX-Virt machine
2eb41c6 Add rx-softmmu
48b2733 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
553c47a hw/rx: Honor -accel qtest
772e51b hw/rx: RX Target hardware definition
e83ed7a hw/char: RX62N serial communication interface (SCI)
bc497be hw/timer: RX62N internal timer modules
489b78e hw/intc: RX62N interrupt controller (ICUa)
e7e59c8 target/rx: Dump bytes for each insn during disassembly
90542e9 target/rx: Collect all bytes during disassembly
59f6e53 target/rx: Emit all disassembly in one prt()
d8274fb target/rx: Use prt_ldmi for XCHG_mr disassembly
2624f8a target/rx: Replace operand with prt_ldmi in disassembler
b035061 target/rx: Disassemble rx_index_addr into a string
a03cc02 target/rx: RX disassembler
675ec3b target/rx: CPU definition
53294dd target/rx: TCG helper
bb455c1 target/rx: TCG translation
77b432f hw/registerfields.h: Add 8bit and 16bit register macros
8d8dcbf qemu/bitops.h: Add extract8 and extract16
9314e24 MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/21 Checking commit 9314e24fff3f (MAINTAINERS: Add RX)
2/21 Checking commit 8d8dcbf0ca8c (qemu/bitops.h: Add extract8 and extract16)
3/21 Checking commit 77b432f0a09a (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/21 Checking commit bb455c1efb29 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/21 Checking commit 53294dd48033 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/21 Checking commit 675ec3be479b (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

total: 0 errors, 1 warnings, 588 lines checked

Patch 6/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/21 Checking commit a03cc022543e (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/21 Checking commit b0350612e125 (target/rx: Disassemble rx_index_addr into a 
string)
9/21 Checking commit 2624f8abcfe9 (target/rx: Replace operand with prt_ldmi in 
disassembler)
10/21 Checking commit d8274fb87fd1 (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
11/21 Checking commit 59f6e535acea (target/rx: Emit all disassembly in one 
prt())
12/21 Checking commit 90542e9f8d0f (target/rx: Collect all bytes during 
disassembly)
13/21 Checking commit e7e59c84dff4 (target/rx: Dump bytes for each insn during 
disassembly)
14/21 Checking commit 489b78e048b9 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/21 Checking commit bc497beb9b62 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/21 Checking commit e83ed7af7074 (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 401 lines checked

Patch 16/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/21 Checking commit 772e51bc3fe9 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 480 lines checked

Patch 17/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/21 Checking commit 553c47ae44cc (hw/rx: Honor -accel qtest)
19/21 Checking commit 48b27337c69b (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
20/21 Checking commit 2eb41c65d957 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

total: 0 errors, 1 warnings, 74 lines checked

Patch 20/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/21 Checking commit e7b4c1ea4eec (BootLinuxConsoleTest: Test the RX-Virt 
machine)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden