Re: [PATCH v26 00/21] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v26 00/21] Add RX archtecture support
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3dc4ce3 BootLinuxConsoleTest: Test the RX-Virt machine
7db9f9b Add rx-softmmu
23cabcc hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
762fe7c hw/rx: Honor -accel qtest
d91f89f hw/rx: RX Target hardware definition
0c6ffe0 hw/char: RX62N serial communication interface (SCI)
e6a5a42 hw/timer: RX62N internal timer modules
38febf0 hw/intc: RX62N interrupt controller (ICUa)
0871fb9 target/rx: Dump bytes for each insn during disassembly
136dde2 target/rx: Collect all bytes during disassembly
d541b2f target/rx: Emit all disassembly in one prt()
56e42be target/rx: Use prt_ldmi for XCHG_mr disassembly
3a4e100 target/rx: Replace operand with prt_ldmi in disassembler
152bc63 target/rx: Disassemble rx_index_addr into a string
c54404e target/rx: RX disassembler
a3f9cb6 target/rx: CPU definition
3766354 target/rx: TCG helper
44c05b7 target/rx: TCG translation
89989a0 hw/registerfields.h: Add 8bit and 16bit register macros
5aa6e53 qemu/bitops.h: Add extract8 and extract16
fcbaac0 MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/21 Checking commit fcbaac0c6ed3 (MAINTAINERS: Add RX)
2/21 Checking commit 5aa6e538fe97 (qemu/bitops.h: Add extract8 and extract16)
3/21 Checking commit 89989a01d9ae (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/21 Checking commit 44c05b78c659 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/21 Checking commit 3766354ea070 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/21 Checking commit a3f9cb69bcd3 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

total: 0 errors, 1 warnings, 588 lines checked

Patch 6/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/21 Checking commit c54404e8c1f4 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/21 Checking commit 152bc63f993c (target/rx: Disassemble rx_index_addr into a 
string)
9/21 Checking commit 3a4e100bebf4 (target/rx: Replace operand with prt_ldmi in 
disassembler)
10/21 Checking commit 56e42be2740a (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
11/21 Checking commit d541b2f36ec7 (target/rx: Emit all disassembly in one 
prt())
12/21 Checking commit 136dde281494 (target/rx: Collect all bytes during 
disassembly)
13/21 Checking commit 0871fb92b151 (target/rx: Dump bytes for each insn during 
disassembly)
14/21 Checking commit 38febf06b563 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/21 Checking commit e6a5a4234074 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/21 Checking commit 0c6ffe06866f (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 401 lines checked

Patch 16/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/21 Checking commit d91f89f85ccd (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 480 lines checked

Patch 17/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/21 Checking commit 762fe7cdc83e (hw/rx: Honor -accel qtest)
19/21 Checking commit 23cabcce4ea2 (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
20/21 Checking commit 7db9f9bfe9dc (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

total: 0 errors, 1 warnings, 74 lines checked

Patch 20/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/21 Checking commit 3dc4ce3fba7e (BootLinuxConsoleTest: Test the RX-Virt 
machine)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden