[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/arm: Honor HCR_EL2.TID3 trapping requirements
From: |
Richard Henderson |
Subject: |
Re: [PATCH] target/arm: Honor HCR_EL2.TID3 trapping requirements |
Date: |
Tue, 26 Nov 2019 10:12:08 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 11/23/19 11:56 AM, Marc Zyngier wrote:
> +static CPAccessResult access_aa64idreg(CPUARMState *env, const ARMCPRegInfo
> *ri,
> + bool isread)
> +{
> + if ((arm_current_el(env) < 2) && (arm_hcr_el2_eff(env) & HCR_TID3)) {
> + return CP_ACCESS_TRAP_EL2;
> + }
> +
> + return CP_ACCESS_OK;
> +}
> +
The only thing I would suggest is to call this access_aa64_tid3, because
tid{0,1,2} also need to be handled in a similar way, and we'll need little
helper functions for those too.
r~
Re: [PATCH] target/arm: Honor HCR_EL2.TID3 trapping requirements,
Richard Henderson <=
Re: [PATCH] target/arm: Honor HCR_EL2.TID3 trapping requirements, Richard Henderson, 2019/11/26