Re: [PATCH] target/arm: Honor HCR_EL2.TID3 trapping requirements

[Peter Maydell]

On Tue, 26 Nov 2019 at 10:12, Richard Henderson
<address@hidden> wrote:
>
> On 11/23/19 11:56 AM, Marc Zyngier wrote:
> > +static CPAccessResult access_aa64idreg(CPUARMState *env, const 
> > ARMCPRegInfo *ri,
> > +                                       bool isread)
> > +{
> > +    if ((arm_current_el(env) < 2) && (arm_hcr_el2_eff(env) & HCR_TID3)) {
> > +        return CP_ACCESS_TRAP_EL2;
> > +    }
> > +
> > +    return CP_ACCESS_OK;
> > +}
> > +
>
> The only thing I would suggest is to call this access_aa64_tid3, because
> tid{0,1,2} also need to be handled in a similar way, and we'll need little
> helper functions for those too.

Good idea, I will make that change also.

-- PMM