Re: [PATCH v4 14/40] target/arm: Recover 4 bits from TBFLAGs

[Richard Henderson]

On 12/4/19 3:43 AM, Alex Bennée wrote:
> I'm not sure if this visual aid helps but here you go:
> 
>  *  31                  20 19    16 15         10 9            0
>  * +----------------------+--------+-------------+--------------+
>  * |                      |        |       TBFLAG_A64           |
>  * |                      |     +--+-------------+--------------+
>  * |     TBFLAG_ANY       |     |   TBFLAG_A32   |              |
>  * |                      |     +-----+----------+  TBFLAG_AM32 |
>  * |                      |           |TBFLAG_M32|              |
>  * +----------------------+-----------+----------+--------------+

Oooh ahh.  Pretty.  Sure, that's helpful.  We'll see how irritating it is to
keep up-to-date as time goes on.  ;-)


>>  void gen_intermediate_code(CPUState *cpu, TranslationBlock *tb, int 
>> max_insns)
>>  {
>> -    DisasContext dc;
>> +    DisasContext dc = { };
> 
> We seemed to have dropped an initialise here which seems unrelated.

Added, not dropped.


r~