[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 02/14] hw/ipmi: Explicit we ignore some QEMUChrEvent i
From: |
Richard Henderson |
Subject: |
Re: [RFC PATCH v2 02/14] hw/ipmi: Explicit we ignore some QEMUChrEvent in IOEventHandler |
Date: |
Wed, 18 Dec 2019 10:47:39 -1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 12/18/19 7:19 AM, Philippe Mathieu-Daudé wrote:
> The Chardev events are listed in the QEMUChrEvent enum. To be
> able to use this enum in the IOEventHandler typedef, we need to
> explicit all the events ignored by this frontend, to silent the
> following GCC warning:
In the title, s/Explicit we/Explicitly/.
Here in the body, "need to be explicit about all the events ignored", "to
silence".
This same grammar cleanup applies to patches 2-13.
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
for all of 2-13.
r~
- [PATCH v2 00/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef, Philippe Mathieu-Daudé, 2019/12/18
- [PATCH v2 01/14] hw/ipmi: Remove unnecessary declarations, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 02/14] hw/ipmi: Explicit we ignore some QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 03/14] hw/char/terminal3270: Explicit ignored QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 04/14] hw/usb/dev-serial: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 05/14] hw/usb/redirect: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 06/14] ccid-card-passthru: Explicit we ignore QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 07/14] vhost-user-crypto: Explicit we ignore some QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 08/14] vhost-user-net: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 09/14] vhost-user-blk: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/18