Re: [RFC PATCH v2 02/14] hw/ipmi: Explicit we ignore some QEMUChrEvent in IOEventHandler

[Philippe Mathieu-Daudé]

On 12/18/19 9:47 PM, Richard Henderson wrote:
> On 12/18/19 7:19 AM, Philippe Mathieu-Daudé wrote:
> > The Chardev events are listed in the QEMUChrEvent enum. To be
> > able to use this enum in the IOEventHandler typedef, we need to
> > explicit all the events ignored by this frontend, to silent the
> > following GCC warning:
>
> In the title, s/Explicit we/Explicitly/.
>
> Here in the body, "need to be explicit about all the events ignored", "to 
> silence".
>
> This same grammar cleanup applies to patches 2-13.

OK I'll fix that.

> Otherwise,
> Reviewed-by: Richard Henderson <address@hidden>
> for all of 2-13.

Thanks!