Re: [RFC PATCH v2 08/14] vhost-user-net: Explicit we ignore few QEMUChrEvent in IOEventHandler

[Michael S. Tsirkin]

On Wed, Dec 18, 2019 at 06:20:03PM +0100, Philippe Mathieu-Daudé wrote:
> The Chardev events are listed in the QEMUChrEvent enum. To be
> able to use this enum in the IOEventHandler typedef, we need to
> explicit all the events ignored by this frontend, to silent the
> following GCC warning:
> 
>     CC      net/vhost-user.o
>   net/vhost-user.c: In function ‘net_vhost_user_event’:
>   net/vhost-user.c:269:5: error: enumeration value ‘CHR_EVENT_BREAK’ not 
> handled in switch [-Werror=switch]
>     269 |     switch (event) {
>         |     ^~~~~~
>   net/vhost-user.c:269:5: error: enumeration value ‘CHR_EVENT_MUX_IN’ not 
> handled in switch [-Werror=switch]
>   net/vhost-user.c:269:5: error: enumeration value ‘CHR_EVENT_MUX_OUT’ not 
> handled in switch [-Werror=switch]
>   cc1: all warnings being treated as errors
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> v2: Add all missing enums
> 
> Cc: "Michael S. Tsirkin" <address@hidden>
> Cc: Jason Wang <address@hidden>

Reviewed-by: Michael S. Tsirkin <address@hidden>

> ---
>  net/vhost-user.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/net/vhost-user.c b/net/vhost-user.c
> index 014199d600..c54c9c7d4c 100644
> --- a/net/vhost-user.c
> +++ b/net/vhost-user.c
> @@ -294,6 +294,11 @@ static void net_vhost_user_event(void *opaque, int event)
>              aio_bh_schedule_oneshot(ctx, chr_closed_bh, opaque);
>          }
>          break;
> +    case CHR_EVENT_BREAK:
> +    case CHR_EVENT_MUX_IN:
> +    case CHR_EVENT_MUX_OUT:
> +        /* Ignore */
> +        break;
>      }
>  
>      if (err) {
> -- 
> 2.21.0