[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/10] build: Avoid build failure when building drivers as mo
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 05/10] build: Avoid build failure when building drivers as modules |
Date: |
Fri, 26 Jun 2020 18:23:00 +0100 |
User-agent: |
Mutt/1.14.0 (2020-05-02) |
On Fri, Jun 26, 2020 at 06:43:02PM +0200, Christophe de Dinechin wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
> ---
> Makefile.objs | 1 +
> Makefile.target | 7 +++++++
> hw/Makefile.objs | 1 +
> 3 files changed, 9 insertions(+)
>
> diff --git a/Makefile.objs b/Makefile.objs
> index e38768c8d5..6703353493 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -86,6 +86,7 @@ endif # CONFIG_SOFTMMU
> # Target-independent parts used in system and user emulation
> common-obj-y += cpus-common.o
> common-obj-y += hw/
> +common-obj-m += hw/
> common-obj-y += qom/
> common-obj-y += disas/
>
> diff --git a/Makefile.target b/Makefile.target
> index 8ed1eba95b..3f3b5ee058 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -179,6 +179,13 @@ endif # CONFIG_SOFTMMU
> dummy := $(call unnest-vars,,obj-y)
> all-obj-y := $(obj-y)
>
> +#
> +# common-obj-m has some crap here, probably as side effect from
> +# filling obj-y. Clear it. Fixes suspicious dependency errors when
> +# building devices as modules.
> +#
> +common-obj-m :=
This comment doesn't fill me with confidence - makes it feel like there's
some more important root cause that needs addressing instead.
> include $(SRC_PATH)/Makefile.objs
> dummy := $(call unnest-vars,.., \
> authz-obj-y \
> diff --git a/hw/Makefile.objs b/hw/Makefile.objs
> index 4cbe5e4e57..d6d387b74b 100644
> --- a/hw/Makefile.objs
> +++ b/hw/Makefile.objs
> @@ -43,4 +43,5 @@ devices-dirs-y += smbios/
> endif
>
> common-obj-y += $(devices-dirs-y)
> +common-obj-m := display/
> obj-y += $(devices-dirs-y)
> --
> 2.26.2
>
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 01/10] modules: Provide macros making it easier to identify module exports, (continued)
- [PATCH 05/10] build: Avoid build failure when building drivers as modules, Christophe de Dinechin, 2020/06/26
- Re: [PATCH 05/10] build: Avoid build failure when building drivers as modules,
Daniel P . Berrangé <=
- [PATCH 06/10] trivial: Remove extra trailing whitespace, Christophe de Dinechin, 2020/06/26
- [PATCH 07/10] qxl - FIXME: Build as module, Christophe de Dinechin, 2020/06/26
- [PATCH 08/10] build: Add SPICE_CFLAGS and SPICE_LIBS to relevant files, Christophe de Dinechin, 2020/06/26
- [PATCH 09/10] spice: Put spice functions in a separate load module, Christophe de Dinechin, 2020/06/26