[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/10] build: Avoid build failure when building drivers as mo
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH 05/10] build: Avoid build failure when building drivers as modules |
Date: |
Tue, 30 Jun 2020 01:26:22 +0200 |
Hi,
> > +#
> > +# common-obj-m has some crap here, probably as side effect from
> > +# filling obj-y. Clear it. Fixes suspicious dependency errors when
> > +# building devices as modules.
> > +#
> > +common-obj-m :=
>
> This comment doesn't fill me with confidence - makes it feel like there's
> some more important root cause that needs addressing instead.
It's my fault, see also
20200624131045.14512-5-kraxel@redhat.com/">https://patchwork.ozlabs.org/project/qemu-devel/patch/20200624131045.14512-5-kraxel@redhat.com/
I think the underlying problem is that the functions building *-m
variables do not properly handle per-target objects. Which has no bad
side effects as long as we never recurse into hw/, but if we want build
devices as modules we have to ...
Unless we want build per-target code as module the above should do the
trick I think.
Better suggestions are welcome of course.
take care,
Gerd
- Re: [PATCH 01/10] modules: Provide macros making it easier to identify module exports, (continued)
- [PATCH 05/10] build: Avoid build failure when building drivers as modules, Christophe de Dinechin, 2020/06/26
- [PATCH 06/10] trivial: Remove extra trailing whitespace, Christophe de Dinechin, 2020/06/26
- [PATCH 07/10] qxl - FIXME: Build as module, Christophe de Dinechin, 2020/06/26
- [PATCH 08/10] build: Add SPICE_CFLAGS and SPICE_LIBS to relevant files, Christophe de Dinechin, 2020/06/26
- [PATCH 09/10] spice: Put spice functions in a separate load module, Christophe de Dinechin, 2020/06/26