[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/10] build: Add SPICE_CFLAGS and SPICE_LIBS to relevant fil
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH 08/10] build: Add SPICE_CFLAGS and SPICE_LIBS to relevant files |
Date: |
Tue, 30 Jun 2020 01:08:43 +0200 |
Hi,
> obj-$(CONFIG_PC) += pc.o pc_sysfw.o
> +pc.o-cflags += $(SPICE_CFLAGS)
Hmm, looks strange. Why does pc.c need spice?
> +qmp-cmds.o-cflags += $(SPICE_CFLAGS)
> +hmp-cmds.o-cflags += $(SPICE_CFLAGS)
spice monitor commands need this I guess?
> +misc.o-cflags += $(SPICE_CFLAGS)
Why this?
> +vl.o-cflags := $(GPROF_CFLAGS) $(SDL_CFLAGS) $(SPICE_CFLAGS)
spice init probably.
> -stub-obj-y += vmgenid.o
> stub-obj-y += sysbus.o
> stub-obj-y += tpm.o
> stub-obj-y += trace-control.o
> +stub-obj-y += vmgenid.o
Huh?
> -spice-app.mo-cflags := $(GIO_CFLAGS)
> -spice-app.mo-libs := $(GIO_LIBS)
> +spice-app.mo-cflags := $(GIO_CFLAGS) $(SPICE_CFLAGS)
> +spice-app.mo-libs := $(GIO_LIBS) $(SPICE_LIBS)
Good.
> --- a/util/module.c
> +++ b/util/module.c
> @@ -22,11 +22,11 @@
> #ifdef CONFIG_MODULE_UPGRADES
> #include "qemu-version.h"
> #endif
> -#ifdef CONFIG_TRACE_RECORDER
> #include "trace/recorder.h"
> -#endif
>
>
> +RECORDER(modules, 16, "QEMU load modules");
> +
> typedef struct ModuleEntry
> {
> void (*init)(void);
> @@ -85,6 +85,15 @@ void register_dso_module_init(void (*fn)(void),
> module_init_type type)
> {
> ModuleEntry *e;
>
> +#ifdef CONFIG_TRACE_RECORDER
> + static const char *name[] = {
> + "MIGRATION", "BLOCK", "OPTS", "QOM",
> + "TRACE", "XEN_BACKEND", "LIBQOS", "FUZZ_TARGET",
> + "MAX"
> + };
> +#endif
> + record(modules, "Register DSO module init %p type %u %+s",
> + fn, type, name[type]);
> init_lists();
>
> e = g_malloc0(sizeof(*e));
Unrelated change.
(the recorder stuff should probably integrate with qemu trace support,
so you can record any trace point qemu has, but that'll be another patch
series ...)
take care,
Gerd
- Re: [PATCH 04/10] spice: Move all the spice-related code in spice-app.so, (continued)
- [PATCH 05/10] build: Avoid build failure when building drivers as modules, Christophe de Dinechin, 2020/06/26
- [PATCH 06/10] trivial: Remove extra trailing whitespace, Christophe de Dinechin, 2020/06/26
- [PATCH 07/10] qxl - FIXME: Build as module, Christophe de Dinechin, 2020/06/26
- [PATCH 08/10] build: Add SPICE_CFLAGS and SPICE_LIBS to relevant files, Christophe de Dinechin, 2020/06/26
- [PATCH 09/10] spice: Put spice functions in a separate load module, Christophe de Dinechin, 2020/06/26
[PATCH 10/10] REMOVE: Instrumentation to show the module functions being replaced, Christophe de Dinechin, 2020/06/26