Re: [PATCH 2/7] hw/hppa: Make number of TLB and BTLB entries configurable

[Richard Henderson]

On 9/1/20 11:34 AM, Helge Deller wrote:
> diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
> index 90aeefe2a4..e9d84d0f03 100644
> --- a/hw/hppa/machine.c
> +++ b/hw/hppa/machine.c
> @@ -72,6 +72,14 @@ static FWCfgState *create_fw_cfg(MachineState *ms)
>      fw_cfg_add_file(fw_cfg, "/etc/firmware-min-version",
>                      g_memdup(&val, sizeof(val)), sizeof(val));
> 
> +    val = cpu_to_le64(HPPA_TLB_ENTRIES);

I guess you don't have a cpu structure here against which you could apply
ARRAY_SIZE?

>      /* ??? The number of entries isn't specified by the architecture.  */
> +    #define HPPA_TLB_ENTRIES        256
> +    #define HPPA_BTLB_ENTRIES       0

What's a btlb entry?
The indented defines are weird.


r~