Re: [PATCH 6/7] hw/display/artist: Fix artist screen resolution

[Richard Henderson]

On 9/2/20 11:09 PM, Helge Deller wrote:
> New patch #3/3:
> 
> From 476aeb9b832ae172a9d6a28aa9e43300dedd419b Mon Sep 17 00:00:00 2001
> Subject: [PATCH] hw/display/artist: Allow screen size up to 2048 lines
> 
> Adjust the ADDR_TO_Y() macro to extract 11 bits, which allows userspace
> to address screen sizes up to 2048 lines (instead of 1024 before).
> 
> Signed-off-by: Helge Deller <deller@gmx.de>
> 
> diff --git a/hw/display/artist.c b/hw/display/artist.c
> index 16d85c65f8..955296d3d8 100644
> --- a/hw/display/artist.c
> +++ b/hw/display/artist.c
> @@ -193,7 +193,7 @@ static const char *artist_reg_name(uint64_t addr)
>  #undef REG_NAME
> 
>  /* artist has a fixed line length of 2048 bytes. */
> -#define ADDR_TO_Y(addr) extract32(addr, 11, 10)
> +#define ADDR_TO_Y(addr) extract32(addr, 11, 11)
>  #define ADDR_TO_X(addr) extract32(addr, 0, 11)
> 
>  static int16_t artist_get_x(uint32_t reg)
> 

Thanks.  All 3 can have a
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~