Re: [PATCH 2/7] hw/hppa: Make number of TLB and BTLB entries configurable

[Richard Henderson]

On 9/2/20 4:16 AM, Helge Deller wrote:
>>> +    val = cpu_to_le64(HPPA_TLB_ENTRIES);
>>
>> I guess you don't have a cpu structure here against which you could apply
>> ARRAY_SIZE?
> 
> You mean to calculate the number of TLB entries based on the static size
> of an array, e.g. ARRAY_SIZE(struct CPUHPPAState.tlb[256]) ?
> I've replaced it intentionally by a constant, because in a follow-up
> patch to improve the TLB-lookup speed, the array gets replaced by a GTree.

Ok.

>> The indented defines are weird.
> 
> How/Why?

Because usually the # is at column 1.


r~