[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 09/38] qapi/common.py: Add indent manager
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v2 09/38] qapi/common.py: Add indent manager |
|
Date: |
Fri, 25 Sep 2020 13:55:06 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
John Snow <jsnow@redhat.com> writes:
> On 9/23/20 10:55 AM, Cleber Rosa wrote:
>> Do you have a use case for returning the level? If not, I'd go
>> without it, and add a "level" property instead, as it'd serve more
>> cases.
>
> __int__ is doing that lifting. I can remove the return.
I like my functions to return something useful.
Use your judgement.
- Re: [PATCH v2 07/38] qapi: add pylintrc, (continued)
Re: [PATCH v2 09/38] qapi/common.py: Add indent manager, Cleber Rosa, 2020/09/23
[PATCH v2 05/38] qapi: Remove wildcard includes, John Snow, 2020/09/22
[PATCH v2 12/38] qapi/common.py: check with pylint, John Snow, 2020/09/22