|
From: | John Snow |
Subject: | Re: [PATCH v2 09/38] qapi/common.py: Add indent manager |
Date: | Fri, 25 Sep 2020 11:41:06 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/25/20 7:55 AM, Markus Armbruster wrote:
John Snow <jsnow@redhat.com> writes:On 9/23/20 10:55 AM, Cleber Rosa wrote:Do you have a use case for returning the level? If not, I'd go without it, and add a "level" property instead, as it'd serve more cases.__int__ is doing that lifting. I can remove the return.I like my functions to return something useful. Use your judgement.
Eh, Cleber had a point. Nothing uses it. (AKA: I already made the edit ...)Like you say, we'll figure out the truly beautiful way to do code generation when we tackle this all together, holistically. What I've got works for now (and isn't terribly complex), let's just roll with it while we fry the bigger fish.
--js
[Prev in Thread] | Current Thread | [Next in Thread] |