[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 09/10] virtio-mem: Require only coordinated discards
From: |
Pankaj Gupta |
Subject: |
Re: [PATCH v2 09/10] virtio-mem: Require only coordinated discards |
Date: |
Wed, 9 Dec 2020 19:51:15 +0100 |
> We implement the RamDiscardMgr interface and only require coordinated
> discarding of RAM to work.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
> Cc: Peter Xu <peterx@redhat.com>
> Cc: Auger Eric <eric.auger@redhat.com>
> Cc: Wei Yang <richard.weiyang@linux.alibaba.com>
> Cc: teawater <teawaterz@linux.alibaba.com>
> Cc: Marek Kedzierski <mkedzier@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> hw/virtio/virtio-mem.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c
> index f419a758f3..99d0712195 100644
> --- a/hw/virtio/virtio-mem.c
> +++ b/hw/virtio/virtio-mem.c
> @@ -687,7 +687,7 @@ static void virtio_mem_device_realize(DeviceState *dev,
> Error **errp)
> return;
> }
>
> - if (ram_block_discard_require(true)) {
> + if (ram_block_coordinated_discard_require(true)) {
> error_setg(errp, "Discarding RAM is disabled");
> return;
> }
> @@ -695,7 +695,7 @@ static void virtio_mem_device_realize(DeviceState *dev,
> Error **errp)
> ret = ram_block_discard_range(rb, 0, qemu_ram_get_used_length(rb));
> if (ret) {
> error_setg_errno(errp, -ret, "Unexpected error discarding RAM");
> - ram_block_discard_require(false);
> + ram_block_coordinated_discard_require(false);
> return;
> }
>
> @@ -738,7 +738,7 @@ static void virtio_mem_device_unrealize(DeviceState *dev)
> virtio_del_queue(vdev, 0);
> virtio_cleanup(vdev);
> g_free(vmem->bitmap);
> - ram_block_discard_require(false);
> + ram_block_coordinated_discard_require(false);
> }
>
> static int virtio_mem_discard_range_cb(const VirtIOMEM *vmem, void *arg,
Reviewed-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
- [PATCH v2 00/10] virtio-mem: vfio support, David Hildenbrand, 2020/12/08
- [PATCH v2 01/10] memory: Introduce RamDiscardMgr for RAM memory regions, David Hildenbrand, 2020/12/08
- [PATCH v2 02/10] virtio-mem: Factor out traversing unplugged ranges, David Hildenbrand, 2020/12/08
- [PATCH v2 03/10] virtio-mem: Implement RamDiscardMgr interface, David Hildenbrand, 2020/12/08
- [PATCH v2 04/10] vfio: Query and store the maximum number of DMA mappings, David Hildenbrand, 2020/12/08
- [PATCH v2 09/10] virtio-mem: Require only coordinated discards, David Hildenbrand, 2020/12/08
- Re: [PATCH v2 09/10] virtio-mem: Require only coordinated discards,
Pankaj Gupta <=
- [PATCH v2 10/10] vfio: Disable only uncoordinated discards, David Hildenbrand, 2020/12/08
- [PATCH v2 05/10] vfio: Support for RamDiscardMgr in the !vIOMMU case, David Hildenbrand, 2020/12/08
- [PATCH v2 06/10] vfio: Support for RamDiscardMgr in the vIOMMU case, David Hildenbrand, 2020/12/08
- [PATCH v2 07/10] softmmu/physmem: Don't use atomic operations in ram_block_discard_(disable|require), David Hildenbrand, 2020/12/08
- [PATCH v2 08/10] softmmu/physmem: Extend ram_block_discard_(require|disable) by two discard types, David Hildenbrand, 2020/12/08