qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 07/10] softmmu/physmem: Don't use atomic operations in ram


From: David Hildenbrand
Subject: Re: [PATCH v2 07/10] softmmu/physmem: Don't use atomic operations in ram_block_discard_(disable|require)
Date: Thu, 10 Dec 2020 16:00:12 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

>>  bool ram_block_discard_is_disabled(void)
>>  {
>> -    return qatomic_read(&ram_block_discard_disabled) > 0;
>> +    return qatomic_read(&ram_block_discard_disablers);
>>  }
> return value won't be bool?

The compiler does type conversion.

!= 0 -> true
== 0 -> false

[...]

> Apart from query above, looks good.
> Reviewed-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>

Thanks!


-- 
Thanks,

David / dhildenb




reply via email to

[Prev in Thread] Current Thread [Next in Thread]