qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 08/10] softmmu/physmem: Extend ram_block_discard_(require|


From: David Hildenbrand
Subject: Re: [PATCH v2 08/10] softmmu/physmem: Extend ram_block_discard_(require|disable) by two discard types
Date: Wed, 9 Dec 2020 20:00:43 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

[...]

>> +/* Disable only uncoordinated disards. */
> s/disards/discards

Thanks!

[...]

>>
>>  bool ram_block_discard_is_required(void)
>>  {
>> -    return qatomic_read(&ram_block_discard_requirers);
>> +    return qatomic_read(&ram_block_discard_requirers) ||
>> +           qatomic_read(&ram_block_coordinated_discard_requirers);
>>  }
> 
> How to differentiate if we have both un-coordinated & coordinated
> cases together?

Checking for both is sufficient for current users - which only care if
any type of discard is required to work. Thanks!

-- 
Thanks,

David / dhildenb




reply via email to

[Prev in Thread] Current Thread [Next in Thread]