[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 55/67] target/sparc: Remove DEBUG_UNALIGNED
From: |
Richard Henderson |
Subject: |
[PATCH v5 55/67] target/sparc: Remove DEBUG_UNALIGNED |
Date: |
Thu, 14 Oct 2021 21:10:41 -0700 |
The printf should have been qemu_log_mask, the parameters
themselves no longer compile, and because this is placed
before unwinding the PC is actively wrong.
We get better (and correct) logging on the other side of
raising the exception, in sparc_cpu_do_interrupt.
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/sparc/ldst_helper.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c
index bbf3601cb1..0549b6adf1 100644
--- a/target/sparc/ldst_helper.c
+++ b/target/sparc/ldst_helper.c
@@ -27,7 +27,6 @@
//#define DEBUG_MMU
//#define DEBUG_MXCC
-//#define DEBUG_UNALIGNED
//#define DEBUG_UNASSIGNED
//#define DEBUG_ASI
//#define DEBUG_CACHE_CONTROL
@@ -364,10 +363,6 @@ static void do_check_align(CPUSPARCState *env,
target_ulong addr,
uint32_t align, uintptr_t ra)
{
if (addr & align) {
-#ifdef DEBUG_UNALIGNED
- printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx
- "\n", addr, env->pc);
-#endif
cpu_raise_exception_ra(env, TT_UNALIGNED, ra);
}
}
@@ -1968,10 +1963,6 @@ void QEMU_NORETURN
sparc_cpu_do_unaligned_access(CPUState *cs, vaddr addr,
SPARCCPU *cpu = SPARC_CPU(cs);
CPUSPARCState *env = &cpu->env;
-#ifdef DEBUG_UNALIGNED
- printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx
- "\n", addr, env->pc);
-#endif
cpu_raise_exception_ra(env, TT_UNALIGNED, retaddr);
}
#endif
--
2.25.1
- Re: [PATCH v5 51/67] target/ppc: Restrict ppc_cpu_do_unaligned_access to sysemu, (continued)
- [PATCH v5 52/67] target/s390x: Implement s390x_cpu_record_sigbus, Richard Henderson, 2021/10/15
- [PATCH v5 47/67] linux-user/hppa: Remove EXCP_UNALIGN handling, Richard Henderson, 2021/10/15
- [PATCH v5 50/67] target/ppc: Set fault address in ppc_cpu_do_unaligned_access, Richard Henderson, 2021/10/15
- [PATCH v5 53/67] linux-user/hppa: Remove POWERPC_EXCP_ALIGN handling, Richard Henderson, 2021/10/15
- [PATCH v5 54/67] target/sh4: Set fault address in superh_cpu_do_unaligned_access, Richard Henderson, 2021/10/15
- [PATCH v5 57/67] target/sparc: Set fault address in sparc_cpu_do_unaligned_access, Richard Henderson, 2021/10/15
- [PATCH v5 55/67] target/sparc: Remove DEBUG_UNALIGNED,
Richard Henderson <=
- [PATCH v5 60/67] tcg: Add helper_unaligned_{ld, st} for user-only sigbus, Richard Henderson, 2021/10/15
- [PATCH v5 58/67] accel/tcg: Report unaligned atomics for user-only, Richard Henderson, 2021/10/15
- [PATCH v5 61/67] linux-user: Handle BUS_ADRALN in host_signal_handler, Richard Henderson, 2021/10/15
- [PATCH v5 64/67] linux-user: Add code for PR_GET/SET_UNALIGN, Richard Henderson, 2021/10/15