[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 61/67] linux-user: Handle BUS_ADRALN in host_signal_handle
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v5 61/67] linux-user: Handle BUS_ADRALN in host_signal_handler |
Date: |
Sat, 30 Oct 2021 01:46:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/15/21 06:10, Richard Henderson wrote:
> Handle BUS_ADRALN via cpu_loop_exit_sigbus, but allow other SIGBUS
> si_codes to continue into the host-to-guest signal coversion code.
Typo "conversion".
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/signal.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index df2c8678d0..81c45bfce9 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
> @@ -860,6 +860,9 @@ static void host_signal_handler(int host_sig, siginfo_t
> *info, void *puc)
> cpu_loop_exit_sigsegv(cpu, guest_addr, access_type, maperr, pc);
> } else {
> sigprocmask(SIG_SETMASK, &uc->uc_sigmask, NULL);
> + if (info->si_code == BUS_ADRALN) {
> + cpu_loop_exit_sigbus(cpu, guest_addr, access_type, pc);
> + }
> }
To the best of my knowledge,
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v5 54/67] target/sh4: Set fault address in superh_cpu_do_unaligned_access, (continued)
- [PATCH v5 54/67] target/sh4: Set fault address in superh_cpu_do_unaligned_access, Richard Henderson, 2021/10/15
- [PATCH v5 57/67] target/sparc: Set fault address in sparc_cpu_do_unaligned_access, Richard Henderson, 2021/10/15
- [PATCH v5 55/67] target/sparc: Remove DEBUG_UNALIGNED, Richard Henderson, 2021/10/15
- [PATCH v5 60/67] tcg: Add helper_unaligned_{ld, st} for user-only sigbus, Richard Henderson, 2021/10/15
- [PATCH v5 58/67] accel/tcg: Report unaligned atomics for user-only, Richard Henderson, 2021/10/15
- [PATCH v5 61/67] linux-user: Handle BUS_ADRALN in host_signal_handler, Richard Henderson, 2021/10/15
- Re: [PATCH v5 61/67] linux-user: Handle BUS_ADRALN in host_signal_handler,
Philippe Mathieu-Daudé <=
- [PATCH v5 64/67] linux-user: Add code for PR_GET/SET_UNALIGN, Richard Henderson, 2021/10/15
- [PATCH v5 67/67] target/sh4: Implement prctl_unalign_sigbus, Richard Henderson, 2021/10/15
- [PATCH v5 63/67] linux-user: Disable more prctl subcodes, Richard Henderson, 2021/10/15
- [PATCH v5 46/67] target/arm: Implement arm_cpu_record_sigbus, Richard Henderson, 2021/10/15
- [PATCH v5 56/67] target/sparc: Split out build_sfsr, Richard Henderson, 2021/10/15
- [PATCH v5 59/67] accel/tcg: Report unaligned load/store for user-only, Richard Henderson, 2021/10/15
- [PATCH v5 65/67] target/alpha: Implement prctl_unalign_sigbus, Richard Henderson, 2021/10/15