|
From: | Mark Cave-Ayland |
Subject: | Re: [PATCH 4/8] mac_via: add GPIO for A/UX mode |
Date: | Fri, 15 Oct 2021 20:59:30 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 |
On 15/10/2021 08:17, Laurent Vivier wrote:
Le 13/10/2021 à 23:21, Mark Cave-Ayland a écrit :Add a new auxmode GPIO that is updated when port B bit 6 is changed indicating whether the hardware is configured for A/UX mode.Stupid question: why do you use GPIO to pass the auxmode information between VIA and GLUE? Can't we use object_property_set_link() to set a pointer to the GLUE object?
For devices that are independent i.e. not contained within others I prefer to restrict the interface to properties that are visible within "info qom-tree" which are MRs and GPIOs. Otherwise GLUE requires knowledge of VIA internals which breaks the device abstraction.
ATB, Mark.
[Prev in Thread] | Current Thread | [Next in Thread] |