[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 22/33] target/mips: Convert MSA 3R instruction format to deco
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 22/33] target/mips: Convert MSA 3R instruction format to decodetree (part 1/4) |
|
Date: |
Sun, 24 Oct 2021 20:57:25 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/24/21 19:52, Richard Henderson wrote:
> On 10/23/21 2:47 PM, Philippe Mathieu-Daudé wrote:
>> +static bool trans_msa_3r_df(DisasContext *ctx, arg_msa_r *a,
>> + void (*gen_msa_3r_df)(TCGv_ptr, TCGv_i32,
>> TCGv_i32,
>> + TCGv_i32, TCGv_i32))
>> +{
>> + TCGv_i32 tdf = tcg_constant_i32(a->df);
>> + TCGv_i32 twd = tcg_const_i32(a->wd);
>> + TCGv_i32 tws = tcg_const_i32(a->ws);
>> + TCGv_i32 twt = tcg_const_i32(a->wt);
>> +
>> + gen_msa_3r_df(cpu_env, tdf, twd, tws, twt);
>
> Missing check_msa_access.
It is included in TRANS_MSA(). How could I make that clearer?
The style I follow is:
- trans_UPPER() -> direct implementation
- trans_lower() -> called via TRANS_xxx() macro