[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 26/33] target/mips: Convert MSA ELM instruction format to dec
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 26/33] target/mips: Convert MSA ELM instruction format to decodetree |
|
Date: |
Wed, 27 Oct 2021 19:27:45 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/24/21 22:52, Richard Henderson wrote:
> On 10/23/21 2:47 PM, Philippe Mathieu-Daudé wrote:
>> +static bool trans_msa_elm_df(DisasContext *ctx, arg_msa_elm *a,
>> + void (*gen_msa_elm_df)(TCGv_ptr, TCGv_i32,
>> + TCGv_i32, TCGv_i32,
>> + TCGv_i32))
>> +{
>> + TCGv_i32 twd;
>> + TCGv_i32 tws;
>> + TCGv_i32 tdf;
>> + TCGv_i32 tn;
>> + uint32_t df, n;
>> +
>> + if (!df_extract(df_elm, a->df, &df, &n)) {
>> + gen_reserved_instruction(ctx);
>> + return true;
>> + }
>
> Again, I think this should happen before the access check.
>
> You could even return false from these extractions, because they
> represent an invalid encoding for this instruction. In a different
> context, there could be another grouped insn that matches.
Yes, you are correct.
- Re: [PATCH 22/33] target/mips: Convert MSA 3R instruction format to decodetree (part 1/4), (continued)
[PATCH 23/33] target/mips: Convert MSA 3R instruction format to decodetree (part 2/4), Philippe Mathieu-Daudé, 2021/10/23
[PATCH 24/33] target/mips: Convert MSA 3R instruction format to decodetree (part 3/4), Philippe Mathieu-Daudé, 2021/10/23
[PATCH 25/33] target/mips: Convert MSA 3R instruction format to decodetree (part 4/4), Philippe Mathieu-Daudé, 2021/10/23
[PATCH 26/33] target/mips: Convert MSA ELM instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23
[PATCH 27/33] target/mips: Convert MSA COPY_U opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/23
[PATCH 29/33] target/mips: Convert MSA MOVE.V opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/23
[PATCH 28/33] target/mips: Convert MSA COPY_S and INSERT opcodes to decodetree, Philippe Mathieu-Daudé, 2021/10/23
[PATCH 30/33] target/mips: Convert CFCMSA and CTCMSA opcodes to decodetree, Philippe Mathieu-Daudé, 2021/10/23
[PATCH 31/33] target/mips: Remove generic MSA opcode, Philippe Mathieu-Daudé, 2021/10/23