[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 27/33] target/mips: Convert MSA COPY_U opcode to decodetree
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 27/33] target/mips: Convert MSA COPY_U opcode to decodetree |
|
Date: |
Wed, 27 Oct 2021 19:40:12 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/24/21 23:01, Richard Henderson wrote:
> On 10/23/21 2:47 PM, Philippe Mathieu-Daudé wrote:
>> +#define TRANS_DF_W64(NAME, trans_func, gen_func) \
>> + TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, \
>> + DF_HALF, DF_WORD, \
>> + gen_func##_b, gen_func##_h, gen_func##_w, NULL)
>
> Again with the table.
>
>> +static bool trans_msa_elm_d64(DisasContext *ctx, arg_msa_elm *a,
>> + enum CPUMIPSMSADataFormat df_max32,
>> + enum CPUMIPSMSADataFormat df_max64,
>
> I think you should just arrange for the entries in the table to be null
> when the element variant is not defined.
Clever, thank you!
- Re: [PATCH 23/33] target/mips: Convert MSA 3R instruction format to decodetree (part 2/4), (continued)
- [PATCH 24/33] target/mips: Convert MSA 3R instruction format to decodetree (part 3/4), Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 25/33] target/mips: Convert MSA 3R instruction format to decodetree (part 4/4), Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 26/33] target/mips: Convert MSA ELM instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 27/33] target/mips: Convert MSA COPY_U opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 29/33] target/mips: Convert MSA MOVE.V opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 28/33] target/mips: Convert MSA COPY_S and INSERT opcodes to decodetree, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 30/33] target/mips: Convert CFCMSA and CTCMSA opcodes to decodetree, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 31/33] target/mips: Remove generic MSA opcode, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 32/33] target/mips: Remove one MSA unnecessary decodetree overlap group, Philippe Mathieu-Daudé, 2021/10/23