qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 20/45] target/arm: Implement SME LD1, ST1


From: Richard Henderson
Subject: Re: [PULL 20/45] target/arm: Implement SME LD1, ST1
Date: Sat, 16 Jul 2022 11:58:04 +0530

On Fri, 15 July 2022, 21:38 Peter Maydell, <peter.maydell@linaro.org> wrote:
> +DO_LD(q, _be, MO_128)
> +DO_LD(q, _le, MO_128)

Coverity complains that these uses of MO_128 result in an
array overrun for the pred_esz_masks[] array, because e.g.
sme_ld1() calls sve_cont_ldst_elements() calls which uses esz
as an index into pred_esz_masks[]. (Multiple coverity issues,
affects both loads and stores.)

Do we just need to add an extra entry to the array for
MO_128 (presumably 0x0001000100010001ull) ?

Yes.  I thought I had done that, but perhaps merely meant to do so.  Thanks in advance.


r~

reply via email to

[Prev in Thread] Current Thread [Next in Thread]