[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH QEMU v5 5/8] migration: Refactor auto-converge capability logic
From: |
~hyman |
Subject: |
[PATCH QEMU v5 5/8] migration: Refactor auto-converge capability logic |
Date: |
Wed, 07 Jun 2023 23:32:51 +0800 |
From: Hyman Huang(黄勇) <yong.huang@smartx.com>
Check if block migration is running before throttling
guest down in auto-converge way.
Note that this modification is kind of like code clean,
because block migration does not depend on auto-converge
capability, so the order of checks can be adjusted.
Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Acked-by: Peter Xu <peterx@redhat.com>
---
migration/ram.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index 88a6c82e63..132f1a81d9 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -994,7 +994,11 @@ static void migration_trigger_throttle(RAMState *rs)
/* During block migration the auto-converge logic incorrectly detects
* that ram migration makes no progress. Avoid this by disabling the
* throttling logic during the bulk phase of block migration. */
- if (migrate_auto_converge() && !blk_mig_bulk_active()) {
+ if (blk_mig_bulk_active()) {
+ return;
+ }
+
+ if (migrate_auto_converge()) {
/* The following detection logic can be refined later. For now:
Check to see if the ratio between dirtied bytes and the approx.
amount of bytes that just got transferred since the last time
--
2.38.5
- [PATCH QEMU v5 0/8] migration: introduce dirtylimit capability, ~hyman, 2023/06/08
- [PATCH QEMU v5 1/8] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit", ~hyman, 2023/06/08
- [PATCH QEMU v5 5/8] migration: Refactor auto-converge capability logic,
~hyman <=
- [PATCH QEMU v5 2/8] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter, ~hyman, 2023/06/08
- [PATCH QEMU v5 7/8] migration: Extend query-migrate to provide dirty page limit info, ~hyman, 2023/06/08
- [PATCH QEMU v5 8/8] tests: Add migration dirty-limit capability test, ~hyman, 2023/06/08
- [PATCH QEMU v5 4/8] migration: Introduce dirty-limit capability, ~hyman, 2023/06/08