Re: [PATCH QEMU v5 8/8] tests: Add migration dirty-limit capability test

[Juan Quintela]

~hyman <hyman@git.sr.ht> wrote:
> From: Hyman Huang(黄勇) <yong.huang@smartx.com>
>
> Add migration dirty-limit capability test if kernel support
> dirty ring.
>
> Migration dirty-limit capability introduce dirty limit
> capability, two parameters: x-vcpu-dirty-limit-period and
> vcpu-dirty-limit are introduced to implement the live
> migration with dirty limit.
>
> The test case does the following things:
> 1. start src, dst vm and enable dirty-limit capability
> 2. start migrate and set cancel it to check if dirty limit
>    stop working.
> 3. restart dst vm
> 4. start migrate and enable dirty-limit capability
> 5. check if migration satisfy the convergence condition
>    during pre-switchover phase.
>
> Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>

> +static void test_migrate_dirty_limit(void)
> +{
> +    g_autofree char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
> +    QTestState *from, *to;
> +    int64_t remaining, throttle_us_per_full;

See comments on previous patch about int64_t vs uint64_t.

Except if negative values have some meaning, it should be uint64_t.

Rest seems correct.

Later, Juan.