[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/8] target/riscv: Use xl instead of mxl for disassemble
From: |
Christoph Muellner |
Subject: |
[PATCH v2 1/8] target/riscv: Use xl instead of mxl for disassemble |
Date: |
Mon, 12 Jun 2023 13:10:27 +0200 |
From: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Disassemble function(plugin_disas, target_disas, monitor_disas) will
always call set_disas_info before disassembling instructions.
plugin_disas and target_disas will always be called under a TB, which
has the same XLEN.
We can't ensure that monitor_disas will always be called under a TB,
but current XLEN will still be a better choice, thus we can ensure at
least the disassemble of the nearest one TB is right.
Signed-off-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
---
target/riscv/cpu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 881bddf393..63faf16499 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -858,9 +858,10 @@ static void riscv_cpu_reset_hold(Object *obj)
static void riscv_cpu_disas_set_info(CPUState *s, disassemble_info *info)
{
RISCVCPU *cpu = RISCV_CPU(s);
+ CPURISCVState *env = &cpu->env;
info->target_info = &cpu->cfg;
- switch (riscv_cpu_mxl(&cpu->env)) {
+ switch (env->xl) {
case MXL_RV32:
info->print_insn = print_insn_riscv32;
break;
--
2.40.1
- [PATCH v2 0/8] disas/riscv: Add vendor extension support, Christoph Muellner, 2023/06/12
- [PATCH v2 1/8] target/riscv: Use xl instead of mxl for disassemble,
Christoph Muellner <=
- [PATCH v2 5/8] disas/riscv: Encapsulate opcode_data into decode, Christoph Muellner, 2023/06/12
- [PATCH v2 6/8] disas/riscv: Provide infrastructure for vendor extensions, Christoph Muellner, 2023/06/12
- [PATCH v2 2/8] target/riscv: Factor out extension tests to cpu_cfg.h, Christoph Muellner, 2023/06/12
- [PATCH v2 4/8] disas/riscv: Make rv_op_illegal a shared enum value, Christoph Muellner, 2023/06/12
- [PATCH v2 7/8] disas/riscv: Add support for XVentanaCondOps, Christoph Muellner, 2023/06/12
- [PATCH v2 3/8] disas/riscv: Move types/constants to new header file, Christoph Muellner, 2023/06/12